Add support for sending a USB SET_CONFIGURATION request.

chrome/browser/extensions/api/device_permissions_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/values_test_util.h"
 #include "chrome/browser/extensions/test_extension_environment.h"
 #include "chrome/test/base/testing_profile.h"
 #include "device/core/device_client.h"
 #include "device/usb/usb_device.h"
 #include "device/usb/usb_device_handle.h"
 #include "extensions/browser/api/device_permissions_manager.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/common/extension.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace extensions {
 
 namespace {
 
 using device::UsbDevice;
 using device::UsbDeviceHandle;
 using device::UsbService;
+using testing::_;
+using testing::DoAll;
 using testing::Return;
+using testing::SetArgPointee;
+
+int next_id;
 
 class MockUsbService : public UsbService {
  public:
   MockUsbService() : mock_device_client(this) {}
 
   MOCK_METHOD1(GetDeviceById, scoped_refptr<UsbDevice>(uint32));
   MOCK_METHOD1(GetDevices, void(std::vector<scoped_refptr<UsbDevice>>*));
 
   // Public wrapper for the protected NotifyDeviceRemove function.
   void NotifyDeviceRemoved(scoped_refptr<UsbDevice> device) {
@@ skipping 10 matching lines @@
 
    private:
     UsbService* usb_service_;
   };
 
   MockDeviceClient mock_device_client;
 };
 
 class MockUsbDevice : public UsbDevice {
  public:
-  MockUsbDevice(const std::string& serial_number, uint32 unique_id)
-      : UsbDevice(0, 0, unique_id), serial_number_(serial_number) {}
+  explicit MockUsbDevice(const std::string& serial_number)
+      : UsbDevice(0, 0, next_id++) {
+    if (serial_number.empty()) {
+      EXPECT_CALL(*this, GetSerialNumber(_)).WillRepeatedly(Return(false));
+    } else {
+      EXPECT_CALL(*this, GetSerialNumber(_))
+          .WillRepeatedly(
+              DoAll(SetArgPointee<0>(base::ASCIIToUTF16(serial_number)),
+                    Return(true)));
+    }
 
+    EXPECT_CALL(*this, GetProduct(_))
+        .WillRepeatedly(
+            DoAll(SetArgPointee<0>(base::ASCIIToUTF16("Test Product")),
+                  Return(true)));
+    EXPECT_CALL(*this, GetManufacturer(_))
+        .WillRepeatedly(
+            DoAll(SetArgPointee<0>(base::ASCIIToUTF16("Test Manufacturer")),
+                  Return(true)));
+  }
+
+  MOCK_METHOD2(RequestUsbAccess, void(int, const base::Callback<void(bool)>&));
   MOCK_METHOD0(Open, scoped_refptr<UsbDeviceHandle>());
   MOCK_METHOD1(Close, bool(scoped_refptr<UsbDeviceHandle>));
-#if defined(OS_CHROMEOS)
-  MOCK_METHOD2(RequestUsbAccess, void(int, const base::Callback<void(bool)>&));
-#endif
-  MOCK_METHOD0(GetConfiguration, const device::UsbConfigDescriptor&());
-
-  virtual bool GetManufacturer(base::string16* manufacturer) {
-    *manufacturer = base::ASCIIToUTF16("Test Manufacturer");
-    return true;
-  }
-
-  virtual bool GetProduct(base::string16* product) {
-    *product = base::ASCIIToUTF16("Test Product");
-    return true;
-  }
-
-  virtual bool GetSerialNumber(base::string16* serial_number) override {
-    if (serial_number_.empty()) {
-      // Return false as if the device does not have or failed to return its
-      // serial number.
-      return false;
-    }
-
-    *serial_number = base::UTF8ToUTF16(serial_number_);
-    return true;
-  }
+  MOCK_METHOD0(GetConfiguration, const device::UsbConfigDescriptor*());
+  MOCK_METHOD1(GetManufacturer, bool(base::string16*));
+  MOCK_METHOD1(GetProduct, bool(base::string16*));
+  MOCK_METHOD1(GetSerialNumber, bool(base::string16*));
 
  private:
   virtual ~MockUsbDevice() {}
-
-  const std::string serial_number_;
 };
 
 void AllowUsbDevice(DevicePermissionsManager* manager,
                     const Extension* extension,
                     scoped_refptr<UsbDevice> device) {
   // If the device cannot provide any of these strings they will simply by
   // empty.
   base::string16 product;
   device->GetProduct(&product);
   base::string16 manufacturer;
@@ skipping 27 matching lines @@
                                 "{"
                                 "  \"app\": {"
                                 "    \"background\": {"
                                 "      \"scripts\": [\"background.js\"]"
                                 "    }"
                                 "  },"
                                 "  \"permissions\": ["
                                 "    \"usb\""
                                 "  ]"
                                 "}"));
-    device0 = new MockUsbDevice("ABCDE", 0);
-    device1 = new MockUsbDevice("", 1);
-    device2 = new MockUsbDevice("12345", 2);
-    device3 = new MockUsbDevice("", 3);
+    device0_ = new MockUsbDevice("ABCDE");
+    device1_ = new MockUsbDevice("");
+    device2_ = new MockUsbDevice("12345");
+    device3_ = new MockUsbDevice("");
     usb_service_ = new MockUsbService();
     UsbService::SetInstanceForTest(usb_service_);
   }
 
   void TearDown() override {
     env_.reset(nullptr);
     UsbService::SetInstanceForTest(nullptr);
   }
 
   scoped_ptr<extensions::TestExtensionEnvironment> env_;
   const extensions::Extension* extension_;
   MockUsbService* usb_service_;
-  scoped_refptr<MockUsbDevice> device0;
-  scoped_refptr<MockUsbDevice> device1;
-  scoped_refptr<MockUsbDevice> device2;
-  scoped_refptr<MockUsbDevice> device3;
+  scoped_refptr<MockUsbDevice> device0_;
+  scoped_refptr<MockUsbDevice> device1_;
+  scoped_refptr<MockUsbDevice> device2_;
+  scoped_refptr<MockUsbDevice> device3_;
 };
 
 TEST_F(DevicePermissionsManagerTest, AllowAndClearDevices) {
   DevicePermissionsManager* manager =
       DevicePermissionsManager::Get(env_->profile());
-  AllowUsbDevice(manager, extension_, device0);
-  AllowUsbDevice(manager, extension_, device1);
+  AllowUsbDevice(manager, extension_, device0_);
+  AllowUsbDevice(manager, extension_, device1_);
 
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
   scoped_refptr<DevicePermissionEntry> device0_entry =
-      FindEntry(device_permissions.get(), device0);
+      FindEntry(device_permissions.get(), device0_);
   ASSERT_TRUE(device0_entry.get());
   scoped_refptr<DevicePermissionEntry> device1_entry =
-      FindEntry(device_permissions.get(), device1);
+      FindEntry(device_permissions.get(), device1_);
   ASSERT_TRUE(device1_entry.get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device2).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device3).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device2_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device3_).get());
   ASSERT_EQ(2U, device_permissions->entries().size());
 
   ASSERT_EQ(base::ASCIIToUTF16(
                 "Test Product from Test Manufacturer (serial number ABCDE)"),
             device0_entry->GetPermissionMessageString());
   ASSERT_EQ(base::ASCIIToUTF16("Test Product from Test Manufacturer"),
             device1_entry->GetPermissionMessageString());
 
   manager->Clear(extension_->id());
 
   device_permissions = manager->GetForExtension(extension_->id());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device0).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device1).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device2).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device3).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device0_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device1_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device2_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device3_).get());
   ASSERT_EQ(0U, device_permissions->entries().size());
 
   // After clearing device it should be possible to grant permission again.
-  AllowUsbDevice(manager, extension_, device0);
-  AllowUsbDevice(manager, extension_, device1);
+  AllowUsbDevice(manager, extension_, device0_);
+  AllowUsbDevice(manager, extension_, device1_);
 
   device_permissions = manager->GetForExtension(extension_->id());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device0).get());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device1).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device2).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device3).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device0_).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device1_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device2_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device3_).get());
 }
 
 TEST_F(DevicePermissionsManagerTest, SuspendExtension) {
   DevicePermissionsManager* manager =
       DevicePermissionsManager::Get(env_->profile());
-  AllowUsbDevice(manager, extension_, device0);
-  AllowUsbDevice(manager, extension_, device1);
+  AllowUsbDevice(manager, extension_, device0_);
+  AllowUsbDevice(manager, extension_, device1_);
 
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device0).get());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device1).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device2).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device3).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device0_).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device1_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device2_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device3_).get());
 
   manager->OnBackgroundHostClose(extension_->id());
 
   device_permissions = manager->GetForExtension(extension_->id());
   // Device 0 is still registered because its serial number has been stored in
   // ExtensionPrefs, it is "persistent".
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device0).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device0_).get());
   // Device 1 does not have uniquely identifying traits and so permission to
   // open it has been dropped when the app's windows have closed and the
   // background page has been suspended.
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device1).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device2).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device3).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device1_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device2_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device3_).get());
 }
 
 TEST_F(DevicePermissionsManagerTest, DisconnectDevice) {
   DevicePermissionsManager* manager =
       DevicePermissionsManager::Get(env_->profile());
-  AllowUsbDevice(manager, extension_, device0);
-  AllowUsbDevice(manager, extension_, device1);
+  AllowUsbDevice(manager, extension_, device0_);
+  AllowUsbDevice(manager, extension_, device1_);
 
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device0).get());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device1).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device2).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device3).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device0_).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device1_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device2_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device3_).get());
 
-  usb_service_->NotifyDeviceRemoved(device0);
-  usb_service_->NotifyDeviceRemoved(device1);
+  usb_service_->NotifyDeviceRemoved(device0_);
+  usb_service_->NotifyDeviceRemoved(device1_);
 
   device_permissions = manager->GetForExtension(extension_->id());
   // Device 0 will be accessible when it is reconnected because it can be
   // recognized by its serial number.
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device0).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device0_).get());
   // Device 1 does not have a serial number and cannot be distinguished from
   // any other device of the same model so the app must request permission again
   // when it is reconnected.
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device1).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device2).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device3).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device1_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device2_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device3_).get());
 }
 
 TEST_F(DevicePermissionsManagerTest, RevokeAndRegrantAccess) {
   DevicePermissionsManager* manager =
       DevicePermissionsManager::Get(env_->profile());
-  AllowUsbDevice(manager, extension_, device0);
-  AllowUsbDevice(manager, extension_, device1);
+  AllowUsbDevice(manager, extension_, device0_);
+  AllowUsbDevice(manager, extension_, device1_);
 
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
   scoped_refptr<DevicePermissionEntry> device0_entry =
-      FindEntry(device_permissions.get(), device0);
+      FindEntry(device_permissions.get(), device0_);
   ASSERT_TRUE(device0_entry.get());
   scoped_refptr<DevicePermissionEntry> device1_entry =
-      FindEntry(device_permissions.get(), device1);
+      FindEntry(device_permissions.get(), device1_);
   ASSERT_TRUE(device1_entry.get());
 
   manager->RemoveEntry(extension_->id(), device0_entry);
   device_permissions = manager->GetForExtension(extension_->id());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device0).get());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device1).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device0_).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device1_).get());
 
-  AllowUsbDevice(manager, extension_, device0);
+  AllowUsbDevice(manager, extension_, device0_);
   device_permissions = manager->GetForExtension(extension_->id());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device0).get());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device1).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device0_).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device1_).get());
 
   manager->RemoveEntry(extension_->id(), device1_entry);
   device_permissions = manager->GetForExtension(extension_->id());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device0).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device1).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device0_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device1_).get());
 
-  AllowUsbDevice(manager, extension_, device1);
+  AllowUsbDevice(manager, extension_, device1_);
   device_permissions = manager->GetForExtension(extension_->id());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device0).get());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device1).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device0_).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device1_).get());
 }
 
 TEST_F(DevicePermissionsManagerTest, UpdateLastUsed) {
   DevicePermissionsManager* manager =
       DevicePermissionsManager::Get(env_->profile());
-  AllowUsbDevice(manager, extension_, device0);
+  AllowUsbDevice(manager, extension_, device0_);
 
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
   scoped_refptr<DevicePermissionEntry> device0_entry =
-      FindEntry(device_permissions.get(), device0);
+      FindEntry(device_permissions.get(), device0_);
   ASSERT_TRUE(device0_entry->last_used().is_null());
 
   manager->UpdateLastUsed(extension_->id(), device0_entry);
   device_permissions = manager->GetForExtension(extension_->id());
-  device0_entry = FindEntry(device_permissions.get(), device0);
+  device0_entry = FindEntry(device_permissions.get(), device0_);
   ASSERT_FALSE(device0_entry->last_used().is_null());
 }
 
 TEST_F(DevicePermissionsManagerTest, LoadPrefs) {
   scoped_ptr<base::Value> prefs_value = base::test::ParseJson(
       "["
       "  {"
       "    \"product_id\": 0,"
       "    \"serial_number\": \"ABCDE\","
       "    \"type\": \"usb\","
       "    \"vendor_id\": 0"
       "  }"
       "]");
   env_->GetExtensionPrefs()->UpdateExtensionPref(extension_->id(), "devices",
                                                  prefs_value.release());
 
   DevicePermissionsManager* manager =
       DevicePermissionsManager::Get(env_->profile());
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
-  ASSERT_TRUE(FindEntry(device_permissions.get(), device0).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device1).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device2).get());
-  ASSERT_FALSE(FindEntry(device_permissions.get(), device3).get());
+  ASSERT_TRUE(FindEntry(device_permissions.get(), device0_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device1_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device2_).get());
+  ASSERT_FALSE(FindEntry(device_permissions.get(), device3_).get());
 }
 
 }  // namespace extensions