Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 826083004: Enable loading V8's initial snapshot from external files on Windows. (Closed)

Created:
5 years, 11 months ago by rmcilroy
Modified:
5 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@v8_ext_win_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable loading V8's initial snapshot from external files on Windows. BUG=421063, 439661 Committed: https://crrev.com/a34c5966abc56212cbecbfec23359d120b6b80a2 Cr-Commit-Position: refs/heads/master@{#311526}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Don't include v8 on iOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M build/common.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
rmcilroy
PTAL, thanks. jochen@chromium.org: Please review changes in Chrome cjhopman@chromium.org: Please review changes in build/common.gypi
5 years, 11 months ago (2015-01-09 14:25:40 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-09 14:26:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826083004/1
5 years, 11 months ago (2015-01-09 18:07:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/108603) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/47349) android_arm64_dbg_recipe ...
5 years, 11 months ago (2015-01-09 18:12:08 UTC) #7
cjhopman
lgtm
5 years, 11 months ago (2015-01-09 18:36:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826083004/20001
5 years, 11 months ago (2015-01-09 19:51:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/41991)
5 years, 11 months ago (2015-01-09 20:41:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826083004/40001
5 years, 11 months ago (2015-01-09 21:29:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826083004/40001
5 years, 11 months ago (2015-01-14 17:36:44 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-14 19:09:36 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 19:10:58 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a34c5966abc56212cbecbfec23359d120b6b80a2
Cr-Commit-Position: refs/heads/master@{#311526}

Powered by Google App Engine
This is Rietveld 408576698