build/common.gypi - Issue 826083004: Enable loading V8's initial snapshot from external files on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 826083004: Enable loading V8's initial snapshot from external files on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8_ext_win_1

Patch Set: Don't include v8 on iOS Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 77912bb22bc498b10a79ba48820f33b2973e59c7..945bc174b3d0dbc372e41df1adb7e9a8a0a82513 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -989,9 +989,9 @@

'optimize_jni_generation%': 0,

}],

- # TODO(baixo): Enable v8_use_external_startup_data

+ # TODO(rmcilroy): Enable v8_use_external_startup_data on ChromeOS

# http://crbug.com/421063

- ['android_webview_build==0 and chromecast==0 and chromeos==0 and (OS=="android" or OS=="linux" or OS=="mac")', {

+ ['android_webview_build==0 and chromecast==0 and chromeos==0 and OS!="ios"', {

'v8_use_external_startup_data%': 1,

}, {

'v8_use_external_startup_data%': 0,

« no previous file with comments | « no previous file | chrome/installer/mini_installer/chrome.release » ('j') | no next file with comments »