Issue 826063003: Make Sky not crash when run in MojoShell.apk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 826063003: Make Sky not crash when run in MojoShell.apk (Closed)

Created:
5 years, 11 months ago by eseidel

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make Sky not crash when run in MojoShell.apk We'll fix both of these issues, but these hacks unblock more important functionality fixes to Sky run on Android. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/750ed5f32b6d720da37964cbe1d94cec59bdd5fc

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	sky/tools/debugger/prompt/prompt.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	sky/viewer/viewer.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

eseidel

5 years, 11 months ago (2015-01-07 01:38:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
750ed5f32b6d720da37964cbe1d94cec59bdd5fc (presubmit successful).