Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: sky/tools/debugger/prompt/prompt.cc

Issue 826063003: Make Sky not crash when run in MojoShell.apk (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/viewer/viewer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/debugger/prompt/prompt.cc
diff --git a/sky/tools/debugger/prompt/prompt.cc b/sky/tools/debugger/prompt/prompt.cc
index 6ef357d1d22183f997c0a9688d1511a52c24c379..fc137b533770bf6cd3d29bf049908f54962ecd3c 100644
--- a/sky/tools/debugger/prompt/prompt.cc
+++ b/sky/tools/debugger/prompt/prompt.cc
@@ -56,7 +56,14 @@ class Prompt : public mojo::ApplicationDelegate {
connection->ConnectToService(&debugger_);
std::cout << "Loading " << url_ << std::endl;
Reload();
+#if !defined(OS_ANDROID)
+ // FIXME: To support device-centric development we need to re-write
+ // prompt.cc to just be a server and have all the command handling move
+ // to python (skydb). prompt.cc would just run until told to quit.
+ // If we don't comment this out then prompt.cc just quits when run headless
+ // as it immediately recieves EOF which it treats as quit.
ScheduleWaitForInput();
+#endif
return true;
}
« no previous file with comments | « no previous file | sky/viewer/viewer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698