win: porting for scoped_temp_dir_test

win: porting for scoped_temp_dir_test

Uses the posix-y CRT functions rather than Win32 API for consistency/similarity
to the POSIX code path as it's localized test code anyway.

R=rsesek@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b0545c2627902a40a25f9bc405f0804758e81800

[Robert Sesek, 2015-01-07 23:38:25]

LGTM

https://codereview.chromium.org/826003003/diff/20001/util/test/scoped_temp_di...
File util/test/scoped_temp_dir_test.cc (right):

https://codereview.chromium.org/826003003/diff/20001/util/test/scoped_temp_di...
util/test/scoped_temp_dir_test.cc:27: #if defined(OS_POSIX)
Should these come before the project #includes?

[scottmg, 2015-01-08 00:16:11]

https://codereview.chromium.org/826003003/diff/20001/util/test/scoped_temp_di...
File util/test/scoped_temp_dir_test.cc (right):

https://codereview.chromium.org/826003003/diff/20001/util/test/scoped_temp_di...
util/test/scoped_temp_dir_test.cc:27: #if defined(OS_POSIX)
On 2015/01/07 23:38:25, Robert Sesek wrote:
> Should these come before the project #includes?

They require build/build_config.h, so must go after that. I could put
build_config.h first, then the #if block, then more project #includes, but I
don't think that's common usage, and isn't mentioned in
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Ord...
.

[scottmg, 2015-01-08 00:16:25]

Committed patchset #2 (id:20001) manually as
b0545c2627902a40a25f9bc405f0804758e81800 (presubmit successful).

[Mark Mentovai, 2015-01-08 17:22:19]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-01-08 17:22:20]

https://codereview.chromium.org/826003003/diff/20001/util/test/scoped_temp_di...
File util/test/scoped_temp_dir_test.cc (right):

https://codereview.chromium.org/826003003/diff/20001/util/test/scoped_temp_di...
util/test/scoped_temp_dir_test.cc:49: EXPECT_EQ(ENOENT, errno) <<
ErrnoMessage("lstat") << " " << path.value();
The string isn’t right for Windows. :(

[scottmg, 2015-01-08 17:39:28]

https://codereview.chromium.org/826003003/diff/20001/util/test/scoped_temp_di...
File util/test/scoped_temp_dir_test.cc (right):

https://codereview.chromium.org/826003003/diff/20001/util/test/scoped_temp_di...
util/test/scoped_temp_dir_test.cc:49: EXPECT_EQ(ENOENT, errno) <<
ErrnoMessage("lstat") << " " << path.value();
On 2015/01/08 17:22:20, Mark Mentovai wrote:
> The string isn’t right for Windows. :(

Oops, thanks: https://codereview.chromium.org/836833003