Issue 825983005: Revert of It is dangerous to ignore SkRect::intersect's return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 825983005: Revert of It is dangerous to ignore SkRect::intersect's return value (Closed)

Created:
5 years, 11 months ago by robertphillips

Modified:
5 years, 11 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of It is dangerous to ignore SkRect::intersect's return value (patchset #6 id:100001 of https://codereview.chromium.org/833943002/) Reason for revert: Still more Chromium clean up to do Original issue's description: > It is dangerous to ignore SkRect::intersect's return value > > Committed: https://skia.googlesource.com/skia/+/152f524fd325b7776b01f84afbfe2fa071648a05 TBR=reed@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/690fc594f11a987ba0e885a7eb01aff363395f12

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -32 lines)			Patch
M	gm/gmmain.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	gm/offsetimagefilter.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	include/core/SkRect.h	View	6 chunks	+9 lines, -11 lines	0 comments	Download
M	src/core/SkScan_AntiPath.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/gpu/GrReducedClip.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/utils/SkGatherPixelRefsAndRects.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of It is dangerous to ignore SkRect::intersect's return value

5 years, 11 months ago (2015-01-07 17:11:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825983005/1

5 years, 11 months ago (2015-01-07 17:12:33 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-07 17:12:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/690fc594f11a987ba0e885a7eb01aff363395f12