gm/offsetimagefilter.cpp - Issue 825983005: Revert of It is dangerous to ignore SkRect::intersect's return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/offsetimagefilter.cpp

Issue 825983005: Revert of It is dangerous to ignore SkRect::intersect's return value (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/offsetimagefilter.cpp

diff --git a/gm/offsetimagefilter.cpp b/gm/offsetimagefilter.cpp

index 3dafed8823ef498a798a99d8b59797d511e6e55d..7fcbe0a04db973ec8355bdac280bef6fc92ab0e9 100644

--- a/gm/offsetimagefilter.cpp

+++ b/gm/offsetimagefilter.cpp

@@ -82,9 +82,8 @@

scaleMatrix.setScale(scale, scale);

SkRect cropRectFloat;

scaleMatrix.mapRect(&cropRectFloat, SkRect::Make(cropRect));

- if (clipRect.intersect(cropRectFloat)) {

- canvas->drawRect(clipRect, strokePaint);

- }

+ clipRect.intersect(cropRectFloat);

+ canvas->drawRect(clipRect, strokePaint);

}

virtual void onDraw(SkCanvas* canvas) {

« no previous file with comments | « gm/gmmain.cpp ('k') | include/core/SkRect.h » ('j') | no next file with comments »