Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 825913005: Avoid MSVC's C6323 warning (use of arithmetic operator on Boolean type) (Closed)

Created:
5 years, 11 months ago by Sven Panne
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid MSVC's C6323 warning (use of arithmetic operator on Boolean type) We could use BoolToInt consistently, but for now let's just fix the warnings. R=jochen@chromium.org Committed: https://crrev.com/c09b26d14b3cea570eb419c404b689ce73488c88 Cr-Commit-Position: refs/heads/master@{#26037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/date.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/utils.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Sven Panne
5 years, 11 months ago (2015-01-13 10:28:05 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-13 10:31:44 UTC) #3
Sven Panne
Committed patchset #1 (id:1) manually as c09b26d14b3cea570eb419c404b689ce73488c88 (presubmit successful).
5 years, 11 months ago (2015-01-13 10:52:50 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 10:52:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c09b26d14b3cea570eb419c404b689ce73488c88
Cr-Commit-Position: refs/heads/master@{#26037}

Powered by Google App Engine
This is Rietveld 408576698