src/date.cc - Issue 825913005: Avoid MSVC's C6323 warning (use of arithmetic operator on Boolean type)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/date.cc

Issue 825913005: Avoid MSVC's C6323 warning (use of arithmetic operator on Boolean type) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/date.cc

diff --git a/src/date.cc b/src/date.cc

index 6b95cb721291bc94f6eba556855c3e8936ff05e7..1f879de1350222b58691f40513339a090e3514a0 100644

--- a/src/date.cc

+++ b/src/date.cc

@@ -103,8 +103,8 @@ void DateCache::YearMonthDayFromDays(

days += is_leap;

// Check if the date is after February.

- if (days >= 31 + 28 + is_leap) {

- days -= 31 + 28 + is_leap;

+ if (days >= 31 + 28 + BoolToInt(is_leap)) {

+ days -= 31 + 28 + BoolToInt(is_leap);

// Find the date starting from March.

for (int i = 2; i < 12; i++) {

if (days < kDaysInMonths[i]) {

« no previous file with comments | « no previous file | src/runtime/runtime-scopes.cc » ('j') | no next file with comments »