Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 825633002: TableCaptionElement is not exposed to accessibility (Closed)

Created:
6 years ago by ramya.v
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TableCaptionElement is not exposed to accessibility Exposing caption role in chromium side BUG=443970, 444910 Committed: https://crrev.com/071bb2b55ce65b72f501629fcacf67a85107d57c Cr-Commit-Position: refs/heads/master@{#310076}

Patch Set 1 #

Patch Set 2 : Disabling caption.html testcase till blink patch gets landed #

Patch Set 3 : Rebasing to latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/common/extensions/api/automation.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/caption-expected-android.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/html/caption-expected-mac.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/caption-expected-win.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
ramya.v
PTAL! Thanks
5 years, 12 months ago (2014-12-24 06:55:10 UTC) #2
ramya.v
On 2014/12/24 06:55:10, ramya.v wrote: > PTAL! > > Thanks @Dominic - Can you please ...
5 years, 12 months ago (2014-12-27 08:58:10 UTC) #3
ramya.v
On 2014/12/27 08:58:10, ramya.v wrote: > On 2014/12/24 06:55:10, ramya.v wrote: > > PTAL! > ...
5 years, 11 months ago (2014-12-31 08:46:51 UTC) #4
dmazzoni
lgtm
5 years, 11 months ago (2015-01-06 07:02:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825633002/40001
5 years, 11 months ago (2015-01-06 07:03:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/20150)
5 years, 11 months ago (2015-01-06 08:41:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825633002/40001
5 years, 11 months ago (2015-01-06 08:44:33 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-06 09:26:05 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 09:28:30 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/071bb2b55ce65b72f501629fcacf67a85107d57c
Cr-Commit-Position: refs/heads/master@{#310076}

Powered by Google App Engine
This is Rietveld 408576698