Convert plist and strings to binary for iOS.

Convert plist and strings to binary for iOS.

For iOS builds, Info.plist and .strings files should be converted to binary.

BUG=gyp:390
R=mark@chromium.org, sdefresne@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/d9823985797fd193c691624632e4f9e614507891

[justincohen, 2014-12-22 19:35:02]

justincohen@chromium.org changed reviewers:
+ sdefresne@chromium.org

[justincohen, 2014-12-22 19:35:03]

PTAL!

[sdefresne, 2014-12-22 20:42:03]

lgtm with nit

https://codereview.chromium.org/825453002/diff/80001/test/ios/gyptest-app-ios.py
File test/ios/gyptest-app-ios.py (right):

https://codereview.chromium.org/825453002/diff/80001/test/ios/gyptest-app-ios...
test/ios/gyptest-app-ios.py:17: proc = subprocess.Popen(['file', file],
stdout=subprocess.PIPE)
nit: you can use subprocess.check_output() instead
(https://docs.python.org/2/library/subprocess.html#subprocess.check_output):

output = subprocess.check_output(['file', file])
if not 'Apple binary property list' in output:

[sdefresne, 2015-02-27 10:08:21]

On 2014/12/22 20:42:03, sdefresne wrote:
> lgtm with nit
> 
>
https://codereview.chromium.org/825453002/diff/80001/test/ios/gyptest-app-ios.py
> File test/ios/gyptest-app-ios.py (right):
> 
>
https://codereview.chromium.org/825453002/diff/80001/test/ios/gyptest-app-ios...
> test/ios/gyptest-app-ios.py:17: proc = subprocess.Popen(['file', file],
> stdout=subprocess.PIPE)
> nit: you can use subprocess.check_output() instead
> (https://docs.python.org/2/library/subprocess.html#subprocess.check_output):
> 
> output = subprocess.check_output(['file', file])
> if not 'Apple binary property list' in output:

Any plan to land this or should it be closed?
Removing self from reviewer as I'm cleaning up my incoming review list.

[sdefresne, 2015-02-27 10:08:26]

sdefresne@chromium.org changed reviewers:
- sdefresne@chromium.org

[justincohen, 2015-03-06 19:28:02]

justincohen@chromium.org changed reviewers:
+ mark@chromium.org, sdefresne@chromium.org

[justincohen, 2015-03-06 19:28:03]

PTAL.  Changed to use proper xcode flags.

https://codereview.chromium.org/825453002/diff/80001/test/ios/gyptest-app-ios.py
File test/ios/gyptest-app-ios.py (right):

https://codereview.chromium.org/825453002/diff/80001/test/ios/gyptest-app-ios...
test/ios/gyptest-app-ios.py:17: proc = subprocess.Popen(['file', file],
stdout=subprocess.PIPE)
On 2014/12/22 20:42:03, sdefresne wrote:
> nit: you can use subprocess.check_output() instead
> (https://docs.python.org/2/library/subprocess.html#subprocess.check_output):
> 
> output = subprocess.check_output(['file', file])
> if not 'Apple binary property list' in output:

Done.

[sdefresne, 2015-03-09 08:54:29]

Still LGTM

[justincohen, 2015-03-09 12:54:54]

mark@ ptal!

[Mark Mentovai, 2015-03-09 13:11:22]

https://codereview.chromium.org/825453002/diff/120001/pylib/gyp/xcode_emulati...
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/825453002/diff/120001/pylib/gyp/xcode_emulati...
pylib/gyp/xcode_emulation.py:219: return
self.xcode_settings[configname].get('INFOPLIST_OUTPUT_FORMAT',
INFOPLIST_OUTPUT_FORMAT should be a textual name like “xml” or “binary”, right?
Here, it looks like you’re treating it as a boolean.

https://codereview.chromium.org/825453002/diff/120001/test/ios/gyptest-app-io...
File test/ios/gyptest-app-ios.py (right):

https://codereview.chromium.org/825453002/diff/120001/test/ios/gyptest-app-io...
test/ios/gyptest-app-ios.py:59: test.pass_test()
You haven’t actually tested that the INFOPLIST_OUTPUT_FORMAT xcode_setting
works. That test doesn’t have to be iOS-specific.

[justincohen, 2015-03-09 14:28:31]

Thanks Mark, I corrected the binary/xml check and added two new tests.  PTAL!

https://codereview.chromium.org/825453002/diff/120001/pylib/gyp/xcode_emulati...
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/825453002/diff/120001/pylib/gyp/xcode_emulati...
pylib/gyp/xcode_emulation.py:219: return
self.xcode_settings[configname].get('INFOPLIST_OUTPUT_FORMAT',
On 2015/03/09 13:11:22, Mark Mentovai wrote:
> INFOPLIST_OUTPUT_FORMAT should be a textual name like “xml” or “binary”,
right?
> Here, it looks like you’re treating it as a boolean.

Corrected and added test.

https://codereview.chromium.org/825453002/diff/120001/test/ios/gyptest-app-io...
File test/ios/gyptest-app-ios.py (right):

https://codereview.chromium.org/825453002/diff/120001/test/ios/gyptest-app-io...
test/ios/gyptest-app-ios.py:59: test.pass_test()
On 2015/03/09 13:11:22, Mark Mentovai wrote:
> You haven’t actually tested that the INFOPLIST_OUTPUT_FORMAT xcode_setting
> works. That test doesn’t have to be iOS-specific.

Added a test for desktop default, ios deafult, and ios overridden.

[Mark Mentovai, 2015-03-09 15:28:24]

Nice, LGTM.

[justincohen, 2015-03-09 16:58:09]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2015-03-09 16:58:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/825453002/#ps140001
(title: "Correct desktop and iOS test")

[commit-bot: I haz the power, 2015-03-09 17:02:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 17:02:09]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[justincohen, 2015-03-09 17:49:21]

Committed patchset #9 (id:160001) manually as
d9823985797fd193c691624632e4f9e614507891 (presubmit successful).