Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: test/mac/gyptest-app.py

Issue 825453002: Convert plist and strings to binary for iOS. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Remove blank line Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/ios/gyptest-app-ios.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mac/gyptest-app.py
diff --git a/test/mac/gyptest-app.py b/test/mac/gyptest-app.py
index 49a5bfae3d6eab3abee503b5c22ebb2ba4ebcec7..5ec4dc29ab08cffe8bdf9ef66400d9642d812cf2 100755
--- a/test/mac/gyptest-app.py
+++ b/test/mac/gyptest-app.py
@@ -17,6 +17,13 @@ import subprocess
import sys
+def CheckFileXMLPropertyList(file):
+ output = subprocess.check_output(['file', file])
+ # The double space after XML is intentional.
+ if not 'XML document text' in output:
+ print 'File: Expected XML document text, got %s' % output
+ test.fail_test()
+
def ExpectEq(expected, actual):
if expected != actual:
print >>sys.stderr, 'Expected "%s", got "%s"' % (expected, actual)
@@ -48,6 +55,7 @@ if sys.platform == 'darwin':
test.must_exist(info_plist)
test.must_contain(info_plist, 'com.google.Test-App-Gyp') # Variable expansion
test.must_not_contain(info_plist, '${MACOSX_DEPLOYMENT_TARGET}');
+ CheckFileXMLPropertyList(info_plist)
if test.format != 'make':
# TODO: Synthesized plist entries aren't hooked up in the make generator.
« no previous file with comments | « test/ios/gyptest-app-ios.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698