Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 825003002: [bindings] Eliminate usage of Handle<> from interface_base.cpp from bindings template. (Closed)

Created:
5 years, 12 months ago by vivekg_samsung
Modified:
5 years, 12 months ago
Reviewers:
haraken, vivekg, Jens Widell
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@bindings-install-v8-class-template
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Eliminate usage of Handle<> from interface_base.cpp from bindings template. R=haraken@chromium.org R=jl@opera.com BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M Source/bindings/templates/interface_base.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
vivekg
PTAL.
5 years, 12 months ago (2014-12-24 09:10:05 UTC) #2
Jens Widell
LGTM
5 years, 12 months ago (2014-12-24 09:12:40 UTC) #3
haraken
LGTM
5 years, 12 months ago (2014-12-24 09:16:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825003002/1
5 years, 12 months ago (2014-12-24 10:31:27 UTC) #8
commit-bot: I haz the power
5 years, 12 months ago (2014-12-24 11:40:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187680

Powered by Google App Engine
This is Rietveld 408576698