Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp - Issue 825003002: [bindings] Eliminate usage of Handle<> from interface_base.cpp from bindings template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

Issue 825003002: [bindings] Eliminate usage of Handle<> from interface_base.cpp from bindings template. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@bindings-install-v8-class-template

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

index c1e0691c67158b2d1d57e582088b2b8ac693a260..65d4f88e8055c404af489e3dc84751686b20472a 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

@@ -43,7 +43,7 @@ static void TestInterfaceNamedConstructorConstructorGetter(v8::Local<v8::String>

static void TestInterfaceNamedConstructorForceSetAttributeOnThis(v8::Local<v8::String> name, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)

{

if (info.This()->IsObject())

- v8::Handle<v8::Object>::Cast(info.This())->ForceSet(name, v8Value);

+ v8::Local<v8::Object>::Cast(info.This())->ForceSet(name, v8Value);

}

static void TestInterfaceNamedConstructorForceSetAttributeOnThisCallback(v8::Local<v8::String> name, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)