Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4749)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java

Issue 824763002: Fix bug where accessibility could "see behind" infobars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "touch exploration mode" Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java
index 16e64f20b31841a896323ea352952bebfb05556a..be4c3127bb6068100b0a7e2727e76117c0eb36a2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java
@@ -21,11 +21,7 @@ import org.chromium.chrome.R;
import java.util.ArrayList;
/**
- * A wrapper class designed to:
- * - consume all touch events. This way the parent view (the FrameLayout ContentView) won't
- * have its onTouchEvent called. If it does, ContentView will process the touch click.
- * We don't want web content responding to clicks on the InfoBars.
- * - allow swapping out of children Views for animations.
+ * A wrapper class designed to allow swapping out of child Views for animations.
*
* Once an InfoBar has been hidden and removed from the InfoBarContainer, it cannot be reused
* because the main panel is discarded after the hiding animation.
@@ -72,12 +68,6 @@ public class ContentWrapperView extends FrameLayout {
return !mInfoBar.areControlsEnabled();
}
- @Override
- public boolean onTouchEvent(MotionEvent event) {
- // Consume all motion events so they do not reach the ContentView.
- return true;
- }
-
/**
* Calculates how tall the InfoBar boundary should be in pixels.
* XHDPI devices and above get a double-tall boundary.
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698