Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: components/user_manager/user_manager_base.h

Issue 824683002: UserManager stack refactoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test fixed. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/user_manager/user_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/user_manager/user_manager_base.h
diff --git a/components/user_manager/user_manager_base.h b/components/user_manager/user_manager_base.h
index ba7cd793bb4a97b4003da49060e9dad3e43fe028..9dc1c9ab9ea4a1c7e77b469a0162d18080f89237 100644
--- a/components/user_manager/user_manager_base.h
+++ b/components/user_manager/user_manager_base.h
@@ -136,7 +136,7 @@ class USER_MANAGER_EXPORT UserManagerBase : public UserManager {
// Loads |users_| from Local State if the list has not been loaded yet.
// Subsequent calls have no effect. Must be called on the UI thread.
- void EnsureUsersLoaded();
+ virtual void EnsureUsersLoaded();
// Handle OAuth token |status| change for |user_id|.
virtual void HandleUserOAuthTokenStatusChange(
@@ -260,6 +260,15 @@ class USER_MANAGER_EXPORT UserManagerBase : public UserManager {
// |UpdateAndCleanUpPublicAccounts|.
UserList users_;
+ // List of all users that are logged in current session. These point to User
+ // instances in |users_|. Only one of them could be marked as active.
+ UserList logged_in_users_;
+
+ // A list of all users that are logged in the current session. In contrast to
+ // |logged_in_users|, the order of this list is least recently used so that
+ // the active user should always be the first one in the list.
+ UserList lru_logged_in_users_;
+
private:
// Stages of loading user list from preferences. Some methods can have
// different behavior depending on stage.
@@ -316,15 +325,6 @@ class USER_MANAGER_EXPORT UserManagerBase : public UserManager {
// Indicates stage of loading user from prefs.
UserLoadStage user_loading_stage_;
- // List of all users that are logged in current session. These point to User
- // instances in |users_|. Only one of them could be marked as active.
- UserList logged_in_users_;
-
- // A list of all users that are logged in the current session. In contrast to
- // |logged_in_users|, the order of this list is least recently used so that
- // the active user should always be the first one in the list.
- UserList lru_logged_in_users_;
-
// True if SessionStarted() has been called.
bool session_started_;
« no previous file with comments | « components/user_manager/user_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698