At some places Blink is using old style character string notation

At some places Blink is using old style character string notation
for Unicode. Replacing those with defined Character Names/Unicodes.

Code refactor, Layout Test not needed

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187866

[h.joshi, 2014-12-30 06:19:59]

Patchset #1 (id:1) has been deleted

[h.joshi, 2014-12-30 12:56:56]

h.joshi@samsung.com changed reviewers:
+ eae@chromium.org

[h.joshi, 2014-12-30 12:57:07]

Pls review

[jbroman, 2014-12-30 14:42:56]

drive-by comment on Font.cpp

https://codereview.chromium.org/824263003/diff/20001/Source/platform/fonts/Fo...
File Source/platform/fonts/Font.cpp (right):

https://codereview.chromium.org/824263003/diff/20001/Source/platform/fonts/Fo...
Source/platform/fonts/Font.cpp:783: FloatRect glyphBoundingBox =
shaper.glyphBoundingBox();
FWIW, these are both just members of HarfBuzzShaper (so I'd expect an optimizer
to do the right thing already, if that's what you're worried about). Seems
legibility-neutral to me, so I don't object, but why is this combined with the
other change, which seems totally unrelated?

[eae, 2014-12-30 16:29:11]

The charcode to constant change looks good but the other changes don't really
have anything to do with it and aren
't needed.

https://codereview.chromium.org/824263003/diff/20001/Source/platform/fonts/sh...
File Source/platform/fonts/shaping/SimpleShaper.cpp (right):

https://codereview.chromium.org/824263003/diff/20001/Source/platform/fonts/sh...
Source/platform/fonts/shaping/SimpleShaper.cpp:108: UChar32 character =
charData.character;
This isn't really needed.

[h.joshi, 2015-01-04 16:22:35]

Made suggested changes, pls review

https://codereview.chromium.org/824263003/diff/20001/Source/platform/fonts/Fo...
File Source/platform/fonts/Font.cpp (right):

https://codereview.chromium.org/824263003/diff/20001/Source/platform/fonts/Fo...
Source/platform/fonts/Font.cpp:783: FloatRect glyphBoundingBox =
shaper.glyphBoundingBox();
Removed these change in new patch.
Yes this change was for the optimizer. Was working on some other issue/patch,
which required changes in this area. 
Combined these changes with old style character string notation changes to
reduce number of patches in same file.

https://codereview.chromium.org/824263003/diff/20001/Source/platform/fonts/sh...
File Source/platform/fonts/shaping/SimpleShaper.cpp (right):

https://codereview.chromium.org/824263003/diff/20001/Source/platform/fonts/sh...
Source/platform/fonts/shaping/SimpleShaper.cpp:108: UChar32 character =
charData.character;
Okey, removed these changes from new patch.

[eae, 2015-01-05 18:57:18]

LGTM

[eae, 2015-01-05 18:57:21]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2015-01-05 18:57:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/824263003/40001

[commit-bot: I haz the power, 2015-01-05 20:14:40]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187866