At some places Blink is using old style character string notation

Source/platform/fonts/Font.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2006, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (c) 2007, 2008, 2010 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 762 matching lines @@
         gc->drawTextBlob(blob, origin, paint);
     }
 }
 
 float Font::floatWidthForComplexText(const TextRun& run, HashSet<const SimpleFontData*>* fallbackFonts, IntRectExtent* glyphBounds) const
 {
     HarfBuzzShaper shaper(this, run, HarfBuzzShaper::NotForTextEmphasis, fallbackFonts);
     if (!shaper.shape())
         return 0;
 
-    glyphBounds->setTop(ceilf(-shaper.glyphBoundingBox().y()));
-    glyphBounds->setBottom(ceilf(shaper.glyphBoundingBox().maxY()));
-    glyphBounds->setLeft(std::max<int>(0, ceilf(-shaper.glyphBoundingBox().x())));
-    glyphBounds->setRight(std::max<int>(0, ceilf(shaper.glyphBoundingBox().maxX() - shaper.totalWidth())));
+    FloatRect glyphBoundingBox = shaper.glyphBoundingBox();

[jbroman, 2014/12/30 14:42:56]

FWIW, these are both just members of HarfBuzzShaper (so I'd expect an optimizer
to do the right thing already, if that's what you're worried about). Seems
legibility-neutral to me, so I don't object, but why is this combined with the
other change, which seems totally unrelated?

[h.joshi, 2015/01/04 16:22:35]

Removed these change in new patch.
Yes this change was for the optimizer. Was working on some other issue/patch,
which required changes in this area. 
Combined these changes with old style character string notation changes to
reduce number of patches in same file.

+    float totalWidth = shaper.totalWidth();
 
-    return shaper.totalWidth();
+    glyphBounds->setTop(ceilf(-glyphBoundingBox.y()));
+    glyphBounds->setBottom(ceilf(glyphBoundingBox.maxY()));
+    glyphBounds->setLeft(std::max<int>(0, ceilf(-glyphBoundingBox.x())));
+    glyphBounds->setRight(std::max<int>(0, ceilf(glyphBoundingBox.maxX() - totalWidth)));
+
+    return totalWidth;
 }
 
 // Return the code point index for the given |x| offset into the text run.
 int Font::offsetForPositionForComplexText(const TextRun& run, float xFloat,
     bool includePartialGlyphs) const
 {
     HarfBuzzShaper shaper(this, run);
     if (!shaper.shape())
         return 0;
     return shaper.offsetForPosition(xFloat);
@@ skipping 157 matching lines @@
                 if (delta <= 0)
                     break;
             }
         }
     }
 
     return offset;
 }
 
 } // namespace blink