ipc/ipc_send_fds_test.cc - Issue 824243004: Adding "static_assert" in lieu of "COMPILE_ASSERT" in ipc module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_send_fds_test.cc

Issue 824243004: Adding "static_assert" in lieu of "COMPILE_ASSERT" in ipc module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_send_fds_test.cc

diff --git a/ipc/ipc_send_fds_test.cc b/ipc/ipc_send_fds_test.cc

index de2ae996c8dba81b4cf6150b554091da9464094c..0e5496e544bb68e09d94af5e9520fe288d0105c8 100644

--- a/ipc/ipc_send_fds_test.cc

+++ b/ipc/ipc_send_fds_test.cc

@@ -38,9 +38,9 @@ const unsigned kNumMessages = 20;

const char* kDevZeroPath = "/dev/zero";

#if defined(OS_POSIX)

-COMPILE_ASSERT(kNumFDsToSend ==

- IPC::MessageAttachmentSet::kMaxDescriptorsPerMessage,

- num_fds_to_send_must_be_the_same_as_the_max_desc_per_message);

+static_assert(kNumFDsToSend ==

+ IPC::MessageAttachmentSet::kMaxDescriptorsPerMessage,

+ "The number of FDs to send must be kMaxDescriptorsPerMessage");

dmichael (off chromium) 2015/01/21 16:21:24 ditto, add a period please, even though you'll hav

#endif

class MyChannelDescriptorListenerBase : public IPC::Listener {

« ipc/ipc_channel_win.cc ('K') | « ipc/ipc_channel_win.cc ('k') | ipc/unix_domain_socket_util.cc » ('j') | no next file with comments »