Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: ipc/ipc_channel_win.cc

Issue 824243004: Adding "static_assert" in lieu of "COMPILE_ASSERT" in ipc module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ipc/ipc_send_fds_test.cc » ('j') | ipc/ipc_send_fds_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_win.cc
diff --git a/ipc/ipc_channel_win.cc b/ipc/ipc_channel_win.cc
index 2ad638b2f67ee4b2f76e03ca7ba7d50117ef8e9b..379f77bd9e1c6f4dc051e8c6ce21cc0b6072da3e 100644
--- a/ipc/ipc_channel_win.cc
+++ b/ipc/ipc_channel_win.cc
@@ -29,8 +29,9 @@ ChannelWin::State::State(ChannelWin* channel) : is_pending(false) {
}
ChannelWin::State::~State() {
- COMPILE_ASSERT(!offsetof(ChannelWin::State, context),
- starts_with_io_context);
+ static_assert(offsetof(ChannelWin::State, context) == 0,
+ "ChannelWin::State should have context as its first data"
+ "member");
dmichael (off chromium) 2015/01/21 16:21:23 Please add a period to end the sentence. "member.
}
ChannelWin::ChannelWin(const IPC::ChannelHandle &channel_handle,
« no previous file with comments | « no previous file | ipc/ipc_send_fds_test.cc » ('j') | ipc/ipc_send_fds_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698