Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 824153003: replace COMPILE_ASSERT with static_assert in ppapi/ (Closed)

Created:
5 years, 12 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in ppapi/ BUG=442514 Committed: https://crrev.com/d349f6d64a3b356b8ac61f57321e4cd2513ed6a7 Cr-Commit-Position: refs/heads/master@{#310010}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -45 lines) Patch
M ppapi/proxy/interface_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_message_utils.h View 5 chunks +10 lines, -10 lines 0 comments Download
M ppapi/shared_impl/id_assignment.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/ppb_gamepad_shared.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/ppb_trace_event_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/private/net_address_private_impl.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M ppapi/thunk/ppb_text_input_thunk.cc View 1 chunk +12 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@teravest: please take a look.
5 years, 11 months ago (2015-01-05 21:59:11 UTC) #2
teravest
lgtm
5 years, 11 months ago (2015-01-05 22:19:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824153003/20001
5 years, 11 months ago (2015-01-05 23:52:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 00:42:36 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 00:43:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d349f6d64a3b356b8ac61f57321e4cd2513ed6a7
Cr-Commit-Position: refs/heads/master@{#310010}

Powered by Google App Engine
This is Rietveld 408576698