ppapi/shared_impl/ppb_trace_event_impl.cc - Issue 824153003: replace COMPILE_ASSERT with static_assert in ppapi/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/ppb_trace_event_impl.cc

Issue 824153003: replace COMPILE_ASSERT with static_assert in ppapi/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase on master Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/shared_impl/ppb_trace_event_impl.cc

diff --git a/ppapi/shared_impl/ppb_trace_event_impl.cc b/ppapi/shared_impl/ppb_trace_event_impl.cc

index ce1afb94b51bb18d824a536088e3ea54a47883bc..6db821ff135c0da38a4e4912fe30a7e4ae05190f 100644

--- a/ppapi/shared_impl/ppb_trace_event_impl.cc

+++ b/ppapi/shared_impl/ppb_trace_event_impl.cc

@@ -39,7 +39,8 @@ void TraceEventImpl::AddTraceEvent(int8_t phase,

const uint64_t arg_values[],

uint8_t flags) {

- COMPILE_ASSERT(sizeof(unsigned long long) == sizeof(uint64_t), msg);

+ static_assert(sizeof(unsigned long long) == sizeof(uint64_t),

+ "unexpected data type sizes");

base::debug::TraceLog::GetInstance()->AddTraceEvent(

phase,