Issue 823643003: Add a TODO comment with a link to bug 444955

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 823643003: Add a TODO comment with a link to bug 444955 (Closed)

Created:
5 years, 12 months ago by ncarter (slow)

Modified:
5 years, 12 months ago

Reviewers:
nasko

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add a TODO comment with a link to bug 444955 BUG=444955 Committed: https://crrev.com/e50f57f52f3cfd62e86b8883e81f290995add5a7 Cr-Commit-Position: refs/heads/master@{#309605}

Created: 5 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/frame_host/render_frame_host_manager_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

nasko

LGTM, though I usually like using https for the bug links in the spirit of ...

5 years, 12 months ago (2014-12-24 00:30:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823643003/1

5 years, 12 months ago (2014-12-24 01:17:18 UTC) #4

commit-bot: I haz the power

5 years, 12 months ago (2014-12-24 02:16:42 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e50f57f52f3cfd62e86b8883e81f290995add5a7
Cr-Commit-Position: refs/heads/master@{#309605}