content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 823643003: Add a TODO comment with a link to bug 444955

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 823643003: Add a TODO comment with a link to bug 444955 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "base/files/file_path.h"	6 #include "base/files/file_path.h"

7 #include "base/strings/utf_string_conversions.h"	7 #include "base/strings/utf_string_conversions.h"

8 #include "base/test/histogram_tester.h"	8 #include "base/test/histogram_tester.h"

9 #include "base/time/time.h"	9 #include "base/time/time.h"

10 #include "content/browser/frame_host/cross_site_transferring_request.h"	10 #include "content/browser/frame_host/cross_site_transferring_request.h"

(...skipping 1884 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1895 FrameHostMsg_Detach(manager->current_frame_host()->GetRoutingID()));	1895 FrameHostMsg_Detach(manager->current_frame_host()->GetRoutingID()));

1896	1896

1897 EXPECT_TRUE(delete_watcher.deleted());	1897 EXPECT_TRUE(delete_watcher.deleted());

1898	1898

1899 EXPECT_EQ(1U, site_instance->active_frame_count());	1899 EXPECT_EQ(1U, site_instance->active_frame_count());

1900 site_instance->decrement_active_frame_count();	1900 site_instance->decrement_active_frame_count();

1901	1901

1902 #if 0	1902 #if 0

1903 // TODO(nick): Currently a proxy to the removed frame lingers in the parent.	1903 // TODO(nick): Currently a proxy to the removed frame lingers in the parent.

1904 // Enable this assert below once the proxies to the subframe are correctly	1904 // Enable this assert below once the proxies to the subframe are correctly

1905 // cleaned up after detach.	1905 // cleaned up after detach. http://crbug.com/444955.

1906 ASSERT_TRUE(site_instance->HasOneRef())	1906 ASSERT_TRUE(site_instance->HasOneRef())

1907 << "This SiteInstance should be destroyable now.";	1907 << "This SiteInstance should be destroyable now.";

1908 #endif	1908 #endif

1909 }	1909 }

1910	1910

1911 } // namespace content	1911 } // namespace content

OLD	NEW