Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1826)

Unified Diff: chrome/browser/metrics/metrics_memory_details_browsertest.cc

Issue 823533004: Move memory histograms generation to MetricsMemoryDetails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better class comment. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_memory_details.cc ('k') | chrome/browser/ui/webui/about_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_memory_details_browsertest.cc
diff --git a/chrome/browser/memory_details_browsertest.cc b/chrome/browser/metrics/metrics_memory_details_browsertest.cc
similarity index 66%
rename from chrome/browser/memory_details_browsertest.cc
rename to chrome/browser/metrics/metrics_memory_details_browsertest.cc
index 9ee40c9997359b96a9e2f3f8b0125e8031c1a175..d21462b26b51abf8155901f6dd5ac1d3302513e2 100644
--- a/chrome/browser/memory_details_browsertest.cc
+++ b/chrome/browser/metrics/metrics_memory_details_browsertest.cc
@@ -2,8 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/memory_details.h"
+#include "chrome/browser/metrics/metrics_memory_details.h"
+#include "base/bind_helpers.h"
#include "base/message_loop/message_loop.h"
#include "base/test/histogram_tester.h"
#include "chrome/test/base/in_process_browser_test.h"
@@ -11,12 +12,13 @@
namespace {
-class TestMemoryDetails : public MemoryDetails {
+class TestMemoryDetails : public MetricsMemoryDetails {
public:
- TestMemoryDetails() {}
+ TestMemoryDetails()
+ : MetricsMemoryDetails(base::Bind(&base::DoNothing), nullptr) {}
void StartFetchAndWait() {
- StartFetch(UPDATE_USER_METRICS);
+ StartFetch();
content::RunMessageLoop();
}
@@ -24,6 +26,7 @@ class TestMemoryDetails : public MemoryDetails {
~TestMemoryDetails() override {}
void OnDetailsAvailable() override {
+ MetricsMemoryDetails::OnDetailsAvailable();
// Exit the loop initiated by StartFetchAndWait().
base::MessageLoop::current()->Quit();
}
@@ -33,16 +36,16 @@ class TestMemoryDetails : public MemoryDetails {
} // namespace
-class MemoryDetailsBrowserTest : public InProcessBrowserTest {
+class MetricsMemoryDetailsBrowserTest : public InProcessBrowserTest {
public:
- MemoryDetailsBrowserTest() {}
- ~MemoryDetailsBrowserTest() override {}
+ MetricsMemoryDetailsBrowserTest() {}
+ ~MetricsMemoryDetailsBrowserTest() override {}
private:
- DISALLOW_COPY_AND_ASSIGN(MemoryDetailsBrowserTest);
+ DISALLOW_COPY_AND_ASSIGN(MetricsMemoryDetailsBrowserTest);
};
-IN_PROC_BROWSER_TEST_F(MemoryDetailsBrowserTest, TestMemoryDetails) {
+IN_PROC_BROWSER_TEST_F(MetricsMemoryDetailsBrowserTest, TestMemoryDetails) {
base::HistogramTester histogram_tester;
scoped_refptr<TestMemoryDetails> details(new TestMemoryDetails);
« no previous file with comments | « chrome/browser/metrics/metrics_memory_details.cc ('k') | chrome/browser/ui/webui/about_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698