Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3404)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/about_ui.cc

Issue 823533004: Move memory histograms generation to MetricsMemoryDetails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better class comment. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_memory_details_browsertest.cc ('k') | chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/about_ui.cc
diff --git a/chrome/browser/ui/webui/about_ui.cc b/chrome/browser/ui/webui/about_ui.cc
index 3dbe9e6de797bdb222faabc3d8a38fe0fd28c97a..05797169e5fa6cff32f456aaf91efe18f86cfb08 100644
--- a/chrome/browser/ui/webui/about_ui.cc
+++ b/chrome/browser/ui/webui/about_ui.cc
@@ -645,8 +645,7 @@ void FinishMemoryDataRequest(
// The AboutMemoryHandler cleans itself up, but |StartFetch()| will want
// the refcount to be greater than 0.
scoped_refptr<AboutMemoryHandler> handler(new AboutMemoryHandler(callback));
- // TODO(jamescook): Maybe this shouldn't update UMA?
- handler->StartFetch(MemoryDetails::UPDATE_USER_METRICS);
+ handler->StartFetch();
} else {
int id = IDR_ABOUT_MEMORY_HTML;
if (path == kMemoryJsPath) {
« no previous file with comments | « chrome/browser/metrics/metrics_memory_details_browsertest.cc ('k') | chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698