Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 823283005: Revert of Add GN interactive UI tests (Closed)

Created:
5 years, 11 months ago by nhiroki
Modified:
5 years, 11 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add GN interactive UI tests (patchset #3 id:40001 of https://codereview.chromium.org/795373005/) Reason for revert: This broke Linux ChromiumOS GN build: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/5292 See also: https://codereview.chromium.org/816393003 Original issue's description: > Add GN interactive UI tests > > TBR=dpranke > > Committed: https://crrev.com/0287a1a1750bbe22d3b4efb29b08b9aed13e723e > Cr-Commit-Position: refs/heads/master@{#310040} TBR=dpranke@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/60f03e08f89f08e3ccb3747edeeb426eb4ce9483 Cr-Commit-Position: refs/heads/master@{#310054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -295 lines) Patch
M ash/ash_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 10 chunks +32 lines, -36 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +6 lines, -246 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M google_apis/google_apis.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/mesa/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nhiroki
Created Revert of Add GN interactive UI tests
5 years, 11 months ago (2015-01-06 04:52:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823283005/1
5 years, 11 months ago (2015-01-06 05:00:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 05:00:56 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 05:01:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60f03e08f89f08e3ccb3747edeeb426eb4ce9483
Cr-Commit-Position: refs/heads/master@{#310054}

Powered by Google App Engine
This is Rietveld 408576698