Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 816393003: Fix GN build on Linux ChromiumOS (Closed)

Created:
5 years, 11 months ago by nhiroki
Modified:
5 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN build on Linux ChromiumOS This is a fix for Linux ChromiumOS GN build: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/5292 "view_event_test_platform_part_ash.cc" is not in 'sources'. BUG=n/a TEST=build TBR=brettw@chromium.org NOTRY=true Committed: https://crrev.com/45dcea9064c39161b112b1810e78de13b044e991 Cr-Commit-Position: refs/heads/master@{#310050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816393003/1
5 years, 11 months ago (2015-01-06 04:29:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 04:30:38 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/45dcea9064c39161b112b1810e78de13b044e991 Cr-Commit-Position: refs/heads/master@{#310050}
5 years, 11 months ago (2015-01-06 04:31:38 UTC) #5
nhiroki
Hmmm... this leads a compile failure on the bot. Let me revert this and the ...
5 years, 11 months ago (2015-01-06 04:47:42 UTC) #6
nhiroki
5 years, 11 months ago (2015-01-06 04:48:52 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/794053007/ by nhiroki@chromium.org.

The reason for reverting is: This broke the GN compile on chromeos:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C....

Powered by Google App Engine
This is Rietveld 408576698