Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: chrome/browser/history/history_service.h

Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_querying_unittest.cc ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index 5a8a05ece5fb0fd55491672aaa01fdb16ed6b493..55dd52d02f576ae7f9afb15b9502532afde955d8 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -163,8 +163,9 @@ class HistoryService : public content::NotificationObserver,
// them.
//
// The context/page ids can be NULL if there is no meaningful tracking
- // information that can be performed on the given URL. The 'page_id' should
- // be the ID of the current session history entry in the given process.
+ // information that can be performed on the given URL. The 'nav_entry_id'
+ // should be the unique ID of the current navigation entry in the given
+ // process.
//
// 'redirects' is an array of redirect URLs leading to this page, with the
// page itself as the last item (so when there is no redirect, it will have
@@ -179,7 +180,7 @@ class HistoryService : public content::NotificationObserver,
void AddPage(const GURL& url,
base::Time time,
history::ContextID context_id,
- int32 page_id,
+ int nav_entry_id,
const GURL& referrer,
const history::RedirectList& redirects,
ui::PageTransition transition,
@@ -204,10 +205,10 @@ class HistoryService : public content::NotificationObserver,
void SetPageTitle(const GURL& url, const base::string16& title);
// Updates the history database with a page's ending time stamp information.
- // The page can be identified by the combination of the context id, the page
- // id and the url.
+ // The page can be identified by the combination of the context id, the
+ // navigation entry id and the url.
void UpdateWithPageEndTime(history::ContextID context_id,
- int32 page_id,
+ int nav_entry_id,
const GURL& url,
base::Time end_ts);
« no previous file with comments | « chrome/browser/history/history_querying_unittest.cc ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698