Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1779)

Unified Diff: chrome/browser/history/history_service.cc

Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/history/history_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.cc
diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc
index a22ac4b0dc819f9d8a7b3f1b74c90bda1288d316..16e04df67f577ad58eb2027c26877adf1f6c51ee 100644
--- a/chrome/browser/history/history_service.cc
+++ b/chrome/browser/history/history_service.cc
@@ -392,7 +392,7 @@ void HistoryService::SetOnBackendDestroyTask(const base::Closure& task) {
void HistoryService::AddPage(const GURL& url,
Time time,
history::ContextID context_id,
- int32 page_id,
+ int nav_entry_id,
const GURL& referrer,
const history::RedirectList& redirects,
ui::PageTransition transition,
@@ -400,7 +400,7 @@ void HistoryService::AddPage(const GURL& url,
bool did_replace_entry) {
DCHECK(thread_checker_.CalledOnValidThread());
AddPage(
- history::HistoryAddPageArgs(url, time, context_id, page_id, referrer,
+ history::HistoryAddPageArgs(url, time, context_id, nav_entry_id, referrer,
redirects, transition, visit_source,
did_replace_entry));
}
@@ -465,13 +465,13 @@ void HistoryService::SetPageTitle(const GURL& url,
}
void HistoryService::UpdateWithPageEndTime(history::ContextID context_id,
- int32 page_id,
+ int nav_entry_id,
const GURL& url,
Time end_ts) {
DCHECK(thread_) << "History service being called after cleanup";
DCHECK(thread_checker_.CalledOnValidThread());
ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::UpdateWithPageEndTime,
- context_id, page_id, url, end_ts);
+ context_id, nav_entry_id, url, end_ts);
}
void HistoryService::AddPageWithDetails(const GURL& url,
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/history/history_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698