Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 822933002: Don't pass -pie when building a shared library build on android (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't pass -pie when building a shared library build on android BUG=none R=ulan@chromium.org LOG=n Committed: https://crrev.com/bbe8b00d6a5704f547f8dcf78ff462c92ce10c17 Cr-Commit-Position: refs/heads/master@{#25938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-23 13:45:53 UTC) #1
ulan
lgtm
6 years ago (2014-12-23 13:49:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/822933002/1
6 years ago (2014-12-23 13:55:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 19:23:02 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-23 19:23:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbe8b00d6a5704f547f8dcf78ff462c92ce10c17
Cr-Commit-Position: refs/heads/master@{#25938}

Powered by Google App Engine
This is Rietveld 408576698