build/android.gypi - Issue 822933002: Don't pass -pie when building a shared library build on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android.gypi

Issue 822933002: Don't pass -pie when building a shared library build on android (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android.gypi

diff --git a/build/android.gypi b/build/android.gypi

index b7fc7147e8d9a992310bdbe02994643c02db5d45..5d3b25a74636ca4b8bf430b94a7835673dd49dc4 100644

--- a/build/android.gypi

+++ b/build/android.gypi

@@ -215,7 +215,7 @@

'-fno-stack-protector',

}],

- ['target_arch=="arm" or target_arch=="arm64" or target_arch=="x64"', {

+ ['(target_arch=="arm" or target_arch=="arm64" or target_arch=="x64") and component!="shared_library"', {

'cflags': [

'-fPIE',

« no previous file with comments | « no previous file | no next file » | no next file with comments »