src/compiler/js-graph.cc - Issue 822923002: [turbofan] Cache float32 constants on the JSGraph level.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-graph.cc

Issue 822923002: [turbofan] Cache float32 constants on the JSGraph level. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-graph.cc

diff --git a/src/compiler/js-graph.cc b/src/compiler/js-graph.cc

index b8a7f976e82ce6e4a91726ea7faff57dc87a4b6b..7759ba14418c29c26aaa165d470958ba1abc0f93 100644

--- a/src/compiler/js-graph.cc

+++ b/src/compiler/js-graph.cc

@@ -174,8 +174,11 @@ Node* JSGraph::NumberConstant(double value) {

Node* JSGraph::Float32Constant(float value) {

- // TODO(turbofan): cache float32 constants.

- return graph()->NewNode(common()->Float32Constant(value));

+ Node** loc = cache_.FindFloat32Constant(value);

+ if (*loc == NULL) {

+ *loc = graph()->NewNode(common()->Float32Constant(value));

+ }

+ return *loc;

}

« no previous file with comments | « src/compiler/common-node-cache.cc ('k') | src/compiler/node-cache.h » ('j') | no next file with comments »