LifecycleObserver::contextDestroyed should be explicitly dispatched promptly when a context is dest…

Source/core/frame/LocalDOMWindow.cpp

Index: Source/core/frame/LocalDOMWindow.cpp
diff --git a/Source/core/frame/LocalDOMWindow.cpp b/Source/core/frame/LocalDOMWindow.cpp
index 0eb295eb957c3f684cf3e37a0385ced090dc1e5f..5d6b3fb49771a98157aa1de372bdee66e77a08f9 100644
--- a/Source/core/frame/LocalDOMWindow.cpp
+++ b/Source/core/frame/LocalDOMWindow.cpp
@@ -628,6 +628,8 @@ void LocalDOMWindow::reset()
 #if ENABLE(ASSERT)
     m_hasBeenReset = true;
 #endif
+
+    LifecycleContext<LocalDOMWindow>::contextDestroyed();

[haraken, 2014/12/23 03:43:44]

This is not a right timing to dispatch contextDestoyed(). It is possible that
LocalDOMWindow gets destructed without LocalDOMWindow::reset() getting called,
and thus this CL hits ASSERT(!m_lifecycleNotifier) in ~LocalDOMWindow().

sof@: Do you probably know a timing when to dispatch
LifecycleContext<LocalDOMWindow>::contextDestoyed()?

[sof, 2014/12/23 14:40:30]

Would it work to tie contextDestroyed() for a DOMWindow to frame destruction
notifications?

 }
 
 bool LocalDOMWindow::isCurrentlyDisplayedInFrame() const