LifecycleObserver::contextDestroyed should be explicitly dispatched promptly when a context is dest…

Source/core/frame/LocalDOMWindow.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 610 matching lines @@
     m_navigator = nullptr;
     m_performance = nullptr;
     m_location = nullptr;
     m_media = nullptr;
     m_sessionStorage = nullptr;
     m_localStorage = nullptr;
     m_applicationCache = nullptr;
 #if ENABLE(ASSERT)
     m_hasBeenReset = true;
 #endif
+
+    LifecycleContext<LocalDOMWindow>::contextDestroyed();

[haraken, 2014/12/23 03:43:44]

This is not a right timing to dispatch contextDestoyed(). It is possible that
LocalDOMWindow gets destructed without LocalDOMWindow::reset() getting called,
and thus this CL hits ASSERT(!m_lifecycleNotifier) in ~LocalDOMWindow().

sof@: Do you probably know a timing when to dispatch
LifecycleContext<LocalDOMWindow>::contextDestoyed()?

[sof, 2014/12/23 14:40:30]

Would it work to tie contextDestroyed() for a DOMWindow to frame destruction
notifications?

 }
 
 bool LocalDOMWindow::isCurrentlyDisplayedInFrame() const
 {
     return frame() && frame()->domWindow() == this && frame()->host();
 }
 
 void LocalDOMWindow::sendOrientationChangeEvent()
 {
     ASSERT(RuntimeEnabledFeatures::orientationEventEnabled());
@@ skipping 1327 matching lines @@
     return m_frameObserver->frame();
 }
 
 v8::Handle<v8::Object> LocalDOMWindow::wrap(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     ASSERT_NOT_REACHED(); // LocalDOMWindow has [Custom=ToV8].
     return v8::Handle<v8::Object>();
 }
 
 } // namespace blink