Issue 8228012: Use separate strings for host- and client-side disconnect buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8228012: Use separate strings for host- and client-side disconnect buttons. (Closed)

Created:
9 years, 2 months ago by Jamie

Modified:
9 years, 2 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use separate strings for host- and client-side disconnect buttons. BUG=99236, 99370 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104916

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use words instead of symbols for Mac shortcut. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
M	remoting/host/plugin/host_script_object.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/webapp/me2mom/_locales/en/messages.json	View	1	1 chunk	+12 lines, -8 lines	0 comments	Download
M	remoting/webapp/me2mom/choice.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

garykac

LGTM http://codereview.chromium.org/8228012/diff/1/remoting/webapp/me2mom/_locales/en/messages.json File remoting/webapp/me2mom/_locales/en/messages.json (right): http://codereview.chromium.org/8228012/diff/1/remoting/webapp/me2mom/_locales/en/messages.json#newcode53 remoting/webapp/me2mom/_locales/en/messages.json:53: "message": "Disconnect (\u2325\u2303\u238b)", Unrelated to this CL. But ...

9 years, 2 months ago (2011-10-11 18:01:58 UTC) #2

Jamie

9 years, 2 months ago (2011-10-11 18:16:33 UTC) #3

http://codereview.chromium.org/8228012/diff/1/remoting/webapp/me2mom/_locales...
File remoting/webapp/me2mom/_locales/en/messages.json (right):

http://codereview.chromium.org/8228012/diff/1/remoting/webapp/me2mom/_locales...
remoting/webapp/me2mom/_locales/en/messages.json:53: "message": "Disconnect
(\u2325\u2303\u238b)",
On 2011/10/11 18:01:58, garykac wrote:
> Unrelated to this CL. But we should use text instead of symbols here.

Done.

Expand Messages | Collapse Messages