base/atomicops_internals_x86_msvc.h - Issue 822713002: Update from https://crrev.com/309415

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/atomicops_internals_x86_msvc.h

Issue 822713002: Update from https://crrev.com/309415 (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/atomicops_internals_x86_msvc.h

diff --git a/base/atomicops_internals_x86_msvc.h b/base/atomicops_internals_x86_msvc.h

index 0269d894a1fa72d592d3e85b824d84612bb0090f..26f181353b4a26505a68fa6c6253449f6a3aed39 100644

--- a/base/atomicops_internals_x86_msvc.h

+++ b/base/atomicops_internals_x86_msvc.h

@@ -55,9 +55,6 @@ inline Atomic32 NoBarrier_AtomicIncrement(volatile Atomic32* ptr,

return Barrier_AtomicIncrement(ptr, increment);

}

-#if !(defined(_MSC_VER) && _MSC_VER >= 1400)

-#error "We require at least vs2005 for MemoryBarrier"

-#endif

inline void MemoryBarrier() {

#if defined(ARCH_CPU_64_BITS)

// See #undef and note at the top of this file.