Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: build/common.gypi

Issue 822713002: Update from https://crrev.com/309415 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 96c0c7b29dfd84bea566dfbd8ed5fd4b992680ca..0bc6c6ac71ddb7259e994bf19a66a8e54ecc8c34 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -614,13 +614,6 @@
# Enable hole punching for the protected video.
'video_hole%': 0,
- # Temporary hack to allow us to unify blink's definitions of load
- # completion. blink uses a crazy set of constraints to determine load
- # completion, but only actually requires them for layout tests. However,
- # we need to maintain all the old behaviors while the plumbing is put in
- # place on both sides of the repo boundary.
- 'enable_load_completion_hacks%': 0,
-
# Automatically select platforms under ozone. Turn this off to
# build only explicitly selected platforms.
'ozone_auto_platforms%': 1,
@@ -1209,7 +1202,6 @@
'use_lto%': '<(use_lto)',
'use_lto_o2%': '<(use_lto_o2)',
'video_hole%': '<(video_hole)',
- 'enable_load_completion_hacks%': '<(enable_load_completion_hacks)',
'support_pre_M6_history_database%': '<(support_pre_M6_history_database)',
'v8_use_external_startup_data%': '<(v8_use_external_startup_data)',
@@ -2161,9 +2153,7 @@
'clang%': 1,
}],
['asan==1 and OS=="mac"', {
- # TODO(glider): we do not strip ASan binaries until the dynamic ASan
- # runtime is fully adopted. See http://crbug.com/242503.
- 'mac_strip_release': 0,
+ 'mac_strip_release': 1,
}],
['tsan==1', {
'use_custom_libcxx%': 1,
@@ -2981,9 +2971,6 @@
['video_hole==1', {
'defines': ['VIDEO_HOLE=1'],
}],
- ['enable_load_completion_hacks==1', {
- 'defines': ['ENABLE_LOAD_COMPLETION_HACKS=1'],
- }],
['v8_use_external_startup_data==1', {
'defines': ['V8_USE_EXTERNAL_STARTUP_DATA'],
}],
@@ -3389,6 +3376,7 @@
'AdditionalOptions': [
'/d2Zi+', # Improve debugging of Release builds.
'/Zc:inline', # Remove unreferenced COMDAT (faster links).
+ '/Gw', # Put data in separate COMDATs.
'<@(win_release_extra_cflags)',
],
},
@@ -5058,16 +5046,6 @@
],
},
],
- 'conditions': [
- ['asan==1', {
- 'variables': {
- 'asan_saves_file': 'asan.saves',
- },
- 'xcode_settings': {
- 'CHROMIUM_STRIP_SAVE_FILE': '<(asan_saves_file)',
- },
- }],
- ],
'target_conditions': [
['mac_pie==1 and release_valgrind_build==0', {
# Turn on position-independence (ASLR) for executables. When
@@ -5098,23 +5076,23 @@
'DEBUG_INFORMATION_FORMAT': 'dwarf-with-dsym',
'DEPLOYMENT_POSTPROCESSING': 'YES',
'STRIP_INSTALLED_PRODUCT': 'YES',
- 'target_conditions': [
- ['_type=="shared_library" or _type=="loadable_module"', {
- # The Xcode default is to strip debugging symbols
- # only (-S). Local symbols should be stripped as
- # well, which will be handled by -x. Xcode will
- # continue to insert -S when stripping even when
- # additional flags are added with STRIPFLAGS.
- 'STRIPFLAGS': '-x',
- }], # _type=="shared_library" or _type=="loadable_module"
- ['_type=="executable"', {
- 'conditions': [
- ['asan==1', {
- 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)',
- }]
- ],
- }], # _type=="executable" and asan==1
- ], # target_conditions
+ 'conditions': [
+ # Only strip non-ASan builds.
+ ['asan==0', {
+ 'target_conditions': [
+ ['_type=="shared_library" or _type=="loadable_module"', {
+ # The Xcode default is to strip debugging symbols
+ # only (-S). Local symbols should be stripped as
+ # well, which will be handled by -x. Xcode will
+ # continue to insert -S when stripping even when
+ # additional flags are added with STRIPFLAGS.
+ 'STRIPFLAGS': '-x',
+ }], # _type=="shared_library" or _type=="loadable_module"
+ ], # target_conditions
+ }, { # asan != 0
+ 'STRIPFLAGS': '-S',
+ }],
+ ],
}, # xcode_settings
}, # configuration "Release"
}, # configurations

Powered by Google App Engine
This is Rietveld 408576698