Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: net/quic/quic_connection_test.cc

Issue 822713002: Update from https://crrev.com/309415 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index 6381c16b4401f25891d568973ee46afaef62a40c..fe117665ec2b2ddfe1a0fee20faa54cef5a84e29 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -1346,11 +1346,8 @@ TEST_P(QuicConnectionTest, TooManySentPackets) {
// Ack packet 1, which leaves more than the limit outstanding.
EXPECT_CALL(*send_algorithm_, OnCongestionEvent(true, _, _, _));
- if (FLAGS_quic_too_many_outstanding_packets) {
- EXPECT_CALL(visitor_,
- OnConnectionClosed(QUIC_TOO_MANY_OUTSTANDING_SENT_PACKETS,
- false));
- }
+ EXPECT_CALL(visitor_, OnConnectionClosed(
+ QUIC_TOO_MANY_OUTSTANDING_SENT_PACKETS, false));
// We're receive buffer limited, so the connection won't try to write more.
EXPECT_CALL(visitor_, OnCanWrite()).Times(0);
@@ -1364,12 +1361,8 @@ TEST_P(QuicConnectionTest, TooManySentPackets) {
TEST_P(QuicConnectionTest, TooManyReceivedPackets) {
EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
-
- if (FLAGS_quic_too_many_outstanding_packets) {
- EXPECT_CALL(visitor_,
- OnConnectionClosed(QUIC_TOO_MANY_OUTSTANDING_RECEIVED_PACKETS,
- false));
- }
+ EXPECT_CALL(visitor_, OnConnectionClosed(
+ QUIC_TOO_MANY_OUTSTANDING_RECEIVED_PACKETS, false));
// Miss every other packet for 1000 packets.
for (QuicPacketSequenceNumber i = 1; i < 1000; ++i) {
@@ -2543,8 +2536,6 @@ TEST_P(QuicConnectionTest, RetransmitPacketsWithInitialEncryption) {
}
TEST_P(QuicConnectionTest, DelayForwardSecureEncryptionUntilClientIsReady) {
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_delay_forward_security, true);
-
// A TaggingEncrypter puts kTagSize copies of the given byte (0x02 here) at
// the end of the packet. We can test this to check which encrypter was used.
use_tagging_decrypter();
@@ -2568,8 +2559,6 @@ TEST_P(QuicConnectionTest, DelayForwardSecureEncryptionUntilClientIsReady) {
}
TEST_P(QuicConnectionTest, DelayForwardSecureEncryptionUntilManyPacketSent) {
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_delay_forward_security, true);
-
// Set a congestion window of 10 packets.
QuicPacketCount congestion_window = 10;
EXPECT_CALL(*send_algorithm_, GetCongestionWindow()).WillRepeatedly(

Powered by Google App Engine
This is Rietveld 408576698