Issue 8226007: WORK_IN_PROGRESS: Do effective TLD lookups using a suffix trie

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8226007: WORK_IN_PROGRESS: Do effective TLD lookups using a suffix trie (Closed)

Created:
9 years, 2 months ago by cbentzel

Modified:
6 years, 3 months ago

Reviewers:
bmcquade1

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

Add support for using a suffix trie instead of a perfect hash to find effective top-level-domains. This uses http://code.google.com/p/domain-registry-provider/ to both generate the trie, as well as to do the lookups. If the GYP variable use_domain_suffix_trie is set to 1, this approach is used. Otherwise, the perfect hash is used.

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -1 line)			Patch
M	.DEPS.git	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	DEPS	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/base/registry_controlled_domain.cc	View	4 chunks	+24 lines, -1 line	0 comments	Download
M	net/net.gyp	View	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

cbentzel

9 years, 2 months ago (2011-10-10 21:35:37 UTC) #1

Bryan - with some small changes to the domain-registry-provider source this
generally works. 

I need to do a lot more testing before flipping the suffix_trie default from 0
to 1.

Expand Messages | Collapse Messages