Issue 822583003: debugger: Move Skia initialization out of the GUI widget class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 822583003: debugger: Move Skia initialization out of the GUI widget class (Closed)

Created:
5 years, 11 months ago by Kimmo Kinnunen

Modified:
5 years, 11 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@scratch-key-uint-warning-fix

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

debugger: Move Skia initialization out of the GUI widget class Move Skia initialization out of the GUI widget class to the main function. Before, Skia may have been already called before the SkGraphics::Init was run. Committed: https://skia.googlesource.com/skia/+/5caff917f5f217e3070762847e6934f714196afb

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -13 lines)			Patch
M	debugger/QT/SkDebuggerGUI.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	debugger/debuggermain.cpp	View	3 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/822583003/1

5 years, 11 months ago (2015-01-02 15:15:01 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-02 15:24:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5caff917f5f217e3070762847e6934f714196afb

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages