debugger/QT/SkDebuggerGUI.cpp - Issue 822583003: debugger: Move Skia initialization out of the GUI widget class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: debugger/QT/SkDebuggerGUI.cpp

Issue 822583003: debugger: Move Skia initialization out of the GUI widget class (Closed) Base URL: https://skia.googlesource.com/skia.git@scratch-key-uint-warning-fix

Patch Set: Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: debugger/QT/SkDebuggerGUI.cpp

diff --git a/debugger/QT/SkDebuggerGUI.cpp b/debugger/QT/SkDebuggerGUI.cpp

index 05f488661668b1ca28840ef1354102f0057ab96c..8004b6da08a754026625401fb852235a08b53371 100644

--- a/debugger/QT/SkDebuggerGUI.cpp

+++ b/debugger/QT/SkDebuggerGUI.cpp

@@ -7,16 +7,12 @@

#include "SkDebuggerGUI.h"

#include "SkForceLinking.h"

-#include "SkGraphics.h"

-#include "SkImageDecoder.h"

#include <QListWidgetItem>

#include "PictureRenderer.h"

#include "SkPicturePlayback.h"

#include "SkPictureRecord.h"

#include "SkPictureData.h"

-__SK_FORCE_IMAGE_DECODER_LINKING;

#if defined(SK_BUILD_FOR_WIN32)

#include "SysTimer_windows.h"

#elif defined(SK_BUILD_FOR_MAC)

@@ -124,12 +120,6 @@ SkDebuggerGUI::SkDebuggerGUI(QWidget *parent) :

fMenuEdit.setDisabled(true);

fMenuNavigate.setDisabled(true);

fMenuView.setDisabled(true);

- SkGraphics::Init();

-SkDebuggerGUI::~SkDebuggerGUI() {

- SkGraphics::Term();

}

void SkDebuggerGUI::actionBreakpoints() {

« no previous file with comments | « debugger/QT/SkDebuggerGUI.h ('k') | debugger/debuggermain.cpp » ('j') | no next file with comments »