extensions/common/user_script_unittest.cc - Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/user_script_unittest.cc

Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another round of comments of Devlin@. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/user_script_unittest.cc

diff --git a/extensions/common/user_script_unittest.cc b/extensions/common/user_script_unittest.cc

index 589b55506f3e7d01f5442cc831b5e4d6ec90ff5c..9dd5d4cf5b94da62ba31ec7263909059d6bffc8a 100644

--- a/extensions/common/user_script_unittest.cc

+++ b/extensions/common/user_script_unittest.cc

@@ -193,7 +193,9 @@ TEST(ExtensionUserScriptTest, Pickle) {

const int64 kId = 12;

script1.set_id(kId);

const std::string kExtensionId = "foo";

- script1.set_extension_id(kExtensionId);

+ ConsumerID id(ConsumerID::EXTENSIONS, kExtensionId, ConsumerID::TAB,

+ false /* is_declarative */);

+ script1.set_consumer_id(id);

Pickle pickle;

script1.Pickle(&pickle);

« extensions/common/consumer_id.cc ('K') | « extensions/common/user_script.cc ('k') | extensions/extensions.gyp » ('j') | extensions/renderer/user_script_injector.cc » ('J')