extensions/renderer/user_script_injector.cc - Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/user_script_injector.cc

Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another round of comments of Devlin@. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/user_script_injector.cc

diff --git a/extensions/renderer/user_script_injector.cc b/extensions/renderer/user_script_injector.cc

index 73ac9f60a839a44787e079db87d84a7847e8bf24..f2abdd8275271b6ce790d883e609aaf7b41c9ccd 100644

--- a/extensions/renderer/user_script_injector.cc

+++ b/extensions/renderer/user_script_injector.cc

@@ -54,10 +54,9 @@ base::LazyInstance<GreasemonkeyApiJsString> g_greasemonkey_api =

} // namespace

-UserScriptInjector::UserScriptInjector(

- const UserScript* script,

- UserScriptSet* script_list,

- bool is_declarative)

+UserScriptInjector::UserScriptInjector(const UserScript* script,

+ UserScriptSet* script_list,

Devlin 2015/01/21 23:25:21 nit: It's best practice to not include changes lik

Xi Han 2015/01/22 17:19:36 Sorry, git cl format does these unnecessary change

+ bool is_declarative)

: script_(script),

script_id_(script_->id()),

extension_id_(script_->extension_id()),

« extensions/common/consumer_id.cc ('K') | « extensions/extensions.gyp ('k') | no next file » | no next file with comments »