Issue 822007: [Mac] If an info bubble window is open when the app is terminating, cancel th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 822007: [Mac] If an info bubble window is open when the app is terminating, cancel th... (Closed)

Created:
10 years, 9 months ago by Bons

Modified:
9 years, 5 months ago

Reviewers:
Avi (use Gerrit), willchan no longer on Chromium

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] If an info bubble window is open when the app is terminating, cancel the fadeout animation to prevent the window object from leaking. BUG=37717 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41229

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/info_bubble_window.mm	View	1	4 chunks	+33 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

LG with comment. http://codereview.chromium.org/822007/diff/1/2 File chrome/browser/cocoa/info_bubble_window.mm (right): http://codereview.chromium.org/822007/diff/1/2#newcode94 chrome/browser/cocoa/info_bubble_window.mm:94: addObserver:self Do we want to add ...

10 years, 9 months ago (2010-03-11 00:02:59 UTC) #2

Bons

http://codereview.chromium.org/822007/diff/1/2 File chrome/browser/cocoa/info_bubble_window.mm (right): http://codereview.chromium.org/822007/diff/1/2#newcode94 chrome/browser/cocoa/info_bubble_window.mm:94: addObserver:self On 2010/03/11 00:02:59, Avi wrote: > Do we ...

10 years, 9 months ago (2010-03-11 00:23:57 UTC) #3

SLGTM

Expand Messages | Collapse Messages