[Mac] If an info bubble window is open when the app is terminating, cancel th...

chrome/browser/cocoa/info_bubble_window.mm

-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/info_bubble_window.h"
 
 #include "base/logging.h"
 #include "base/scoped_nsobject.h"
 #import "third_party/GTM/AppKit/GTMNSAnimation+Duration.h"
 
 namespace {
 const CGFloat kOrderInSlideOffset = 10;
 const NSTimeInterval kOrderInAnimationDuration = 0.2;
 const NSTimeInterval kOrderOutAnimationDuration = 0.15;
+// The minimum representable time interval.  This can be used as the value
+// passed to +[NSAnimationContext setDuration:] to stop an in-progress
+// animation as quickly as possible.
+const NSTimeInterval kMinimumTimeInterval =
+    std::numeric_limits<NSTimeInterval>::min();
 }
 
-@interface InfoBubbleWindow (Private)
+@interface InfoBubbleWindow(Private)
+- (void)appIsTerminating;
 - (void)finishCloseAfterAnimation;
 @end
 
 // A delegate object for watching the alphaValue animation on InfoBubbleWindows.
 // An InfoBubbleWindow instance cannot be the delegate for its own animation
 // because CAAnimations retain their delegates, and since the InfoBubbleWindow
 // retains its animations a retain loop would be formed.
 @interface InfoBubbleWindowCloser : NSObject {
  @private
   InfoBubbleWindow* window_;  // Weak. Window to close.
@@ skipping 48 matching lines @@
     // Notice that only the alphaValue Animation is replaced in case
     // superclasses set up animations.
     CAAnimation* alphaAnimation = [CABasicAnimation animation];
     scoped_nsobject<InfoBubbleWindowCloser> delegate(
         [[InfoBubbleWindowCloser alloc] initWithWindow:self]);
     [alphaAnimation setDelegate:delegate];
     NSMutableDictionary* animations =
         [NSMutableDictionary dictionaryWithDictionary:[self animations]];
     [animations setObject:alphaAnimation forKey:@"alphaValue"];
     [self setAnimations:animations];
+
+    [[NSNotificationCenter defaultCenter]
+        addObserver:self
+           selector:@selector(appIsTerminating)
+               name:NSApplicationWillTerminateNotification
+             object:[NSApplication sharedApplication]];
   }
   return self;
 }
 
+- (void)dealloc {
+  [[NSNotificationCenter defaultCenter] removeObserver:self];
+  [super dealloc];
+}
+
 // According to
 // http://www.cocoabuilder.com/archive/message/cocoa/2006/6/19/165953,
 // NSBorderlessWindowMask windows cannot become key or main. In this
 // case, this is not a desired behavior. As an example, the bubble could have
 // buttons.
 - (BOOL)canBecomeKeyWindow {
   return YES;
 }
 
 - (void)close {
   // Block the window from receiving events while it fades out.
   closing_ = YES;
 
   if (!delayOnClose_) {
     [self finishCloseAfterAnimation];
   } else {
     // Apply animations to hide self.
     [NSAnimationContext beginGrouping];
     [[NSAnimationContext currentContext]
         gtm_setDuration:kOrderOutAnimationDuration];
     [[self animator] setAlphaValue:0.0];
     [NSAnimationContext endGrouping];
   }
 }
 
+// If the app is terminating but the window is still fading out, cancel
+// the animation and close the window to prevent it from leaking.
+- (void)appIsTerminating {
+  if (!delayOnClose_)
+    return;  // The close has already happened with no Core Animation.
+
+  // Cancel the current animation so that it closes immediately, triggering
+  // |finishCloseAfterAnimation|.
+  [NSAnimationContext beginGrouping];
+  [[NSAnimationContext currentContext] setDuration:kMinimumTimeInterval];
+  [[self animator] setAlphaValue:0.0];
+  [NSAnimationContext endGrouping];
+}
+
 // Called by InfoBubbleWindowCloser when the window is to be really closed
 // after the fading animation is complete.
 - (void)finishCloseAfterAnimation {
   if (closing_)
     [super close];
 }
 
 // Adds animation for info bubbles being ordered to the front.
 - (void)orderWindow:(NSWindowOrderingMode)orderingMode
          relativeTo:(NSInteger)otherWindowNumber {
@@ skipping 27 matching lines @@
 - (void)sendEvent:(NSEvent*)theEvent {
   if (!closing_)
     [super sendEvent:theEvent];
 }
 
 - (BOOL)isClosing {
   return closing_;
 }
 
 @end