[rAC, OSX] Autofill text field hot keys.

[rAC, OSX] Autofill text field hot keys.

Text fields in the requestAutocomplete dialog need to intercept several
key messages to allow controlling the autocomplete popup field. Most
notably, cursor up/down, page up/down, tab, and escape.

BUG=321319, 321330
R=rsesek@chromium.org
TEST=Bring up rAC dialog, click in textfield to show autocomplete popup. Verify keyboard shortcuts work

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236894

[Robert Sesek, 2013-11-22 16:52:39]

https://codereview.chromium.org/82193002/diff/50002/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_input_field.h (right):

https://codereview.chromium.org/82193002/diff/50002/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_input_field.h:30: // keyEvent should
return kKeyEventHandled if it handled the event, or
|keyEvent| presumably references the method name, right? If so, its name is
really |-keyEvent:forInput:|. Maybe just say "This" ?

https://codereview.chromium.org/82193002/diff/50002/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_section_container.mm (right):

https://codereview.chromium.org/82193002/diff/50002/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_section_container.mm:258: // Only
handle keyDown, to handle key repeats without duplicates.
This isn't only handling keyDown. This is merely not handling KeyUp. What about
RawKeyDown and Char events?

[groby-ooo-7-16, 2013-11-22 21:31:32]

BTW - apologies for the _four_ e-mails. AppEngine hiccups :(

https://codereview.chromium.org/82193002/diff/50002/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_input_field.h (right):

https://codereview.chromium.org/82193002/diff/50002/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_input_field.h:30: // keyEvent should
return kKeyEventHandled if it handled the event, or
On 2013/11/22 16:52:39, rsesek wrote:
> |keyEvent| presumably references the method name, right? If so, its name is
> really |-keyEvent:forInput:|. Maybe just say "This" ?

Done.

https://codereview.chromium.org/82193002/diff/50002/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_section_container.mm (right):

https://codereview.chromium.org/82193002/diff/50002/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_section_container.mm:258: // Only
handle keyDown, to handle key repeats without duplicates.
On 2013/11/22 16:52:39, rsesek wrote:
> This isn't only handling keyDown. This is merely not handling KeyUp. What
about
> RawKeyDown and Char events?

Done.

[Robert Sesek, 2013-11-22 21:37:34]

LGTM

[commit-bot: I haz the power, 2013-11-22 21:55:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/82193002/190001

[commit-bot: I haz the power, 2013-11-23 01:11:34]

Change committed as 236894