[rAC, OSX] Autofill text field hot keys.

chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_section_container.h"
 
 #include <algorithm>
 
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_view_delegate.h"
 #include "chrome/browser/ui/chrome_style.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_section_view.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_textfield.h"
 #import "chrome/browser/ui/cocoa/autofill/layout_view.h"
 #include "chrome/browser/ui/cocoa/autofill/simple_grid_layout.h"
 #import "chrome/browser/ui/cocoa/image_button_cell.h"
 #import "chrome/browser/ui/cocoa/menu_button.h"
 #include "components/autofill/core/browser/autofill_type.h"
+#include "content/public/browser/native_web_keyboard_event.h"
 #include "grit/theme_resources.h"
 #import "ui/base/cocoa/menu_controller.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/models/combobox_model.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace {
 
 // Constants used for layouting controls. These variables are copied from
 // "ui/views/layout/layout_constants.h".
@@ skipping 211 matching lines @@
   } else {
     [inputs_ setFrame:controlFrame];
   }
   [label_ setFrame:labelFrame];
   [suggestButton_ setFrame:buttonFrame];
   [inputs_ setHidden:showSuggestions_];
   [[suggestContainer_ view] setHidden:!showSuggestions_];
   [view_ setFrameSize:viewFrame.size];
 }
 
+- (KeyEventHandled)keyEvent:(NSEvent*)event forInput:(id)sender {
+  content::NativeWebKeyboardEvent webEvent(event);
+
+  // Only handle keyDown, to handle key repeats without duplicates.

[Robert Sesek, 2013/11/22 16:52:39]

This isn't only handling keyDown. This is merely not handling KeyUp. What about
RawKeyDown and Char events?

[groby-ooo-7-16, 2013/11/22 21:31:32]

Done.

+  if (webEvent.type == content::NativeWebKeyboardEvent::KeyUp)
+    return kKeyEventNotHandled;
+
+  // Allow the delegate to intercept key messages.
+  if (delegate_->HandleKeyPressEventInInput(webEvent))
+    return kKeyEventHandled;
+  return kKeyEventNotHandled;
+}
+
 - (void)onMouseDown:(NSControl<AutofillInputField>*)field {
   [self textfieldEditedOrActivated:field edited:NO];
   [validationDelegate_ updateMessageForField:field];
 }
 
 - (void)fieldBecameFirstResponder:(NSControl<AutofillInputField>*)field {
   [validationDelegate_ updateMessageForField:field];
 }
 
 - (void)didChange:(id)sender {
@@ skipping 374 matching lines @@
 - (void)activateFieldForInput:(const autofill::DetailInput&)input {
   if ([self detailInputForType:input.type] != &input)
     return;
 
   NSControl<AutofillInputField>* field = [inputs_ viewWithTag:input.type];
   [[field window] makeFirstResponder:field];
   [self textfieldEditedOrActivated:field edited:NO];
 }
 
 @end