Chromium Code Reviews

Issue 821673004: replace COMPILE_ASSERT with static_assert in chrome/installer/ (Closed)

Created:
5 years, 12 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in chrome/installer/ BUG=442514 Committed: https://crrev.com/b4aadc32a7fd6d42ac3cc9adbb20a8ee4a267572 Cr-Commit-Position: refs/heads/master@{#309684}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+38 lines, -43 lines)
M chrome/installer/mini_installer/mini_string.h View 2 chunks +1 line, -8 lines 0 comments
M chrome/installer/setup/setup_main.cc View 2 chunks +4 lines, -4 lines 0 comments
M chrome/installer/util/channel_info.cc View 1 chunk +2 lines, -2 lines 0 comments
M chrome/installer/util/delete_tree_work_item.cc View 1 chunk +2 lines, -2 lines 0 comments
M chrome/installer/util/google_update_settings_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments
M chrome/installer/util/install_util.cc View 1 chunk +2 lines, -2 lines 0 comments
M chrome/installer/util/installation_state.cc View 1 chunk +8 lines, -8 lines 0 comments
M chrome/installer/util/installer_state.cc View 1 chunk +4 lines, -4 lines 0 comments
M chrome/installer/util/logging_installer.h View 1 chunk +3 lines, -2 lines 0 comments
M chrome/installer/util/shell_util.cc View 1 chunk +2 lines, -1 line 0 comments
M chrome/installer/util/util_constants.h View 2 chunks +5 lines, -5 lines 0 comments

Messages

Total messages: 12 (4 generated)
Mostyn Bramley-Moore
@gab: PTAL
5 years, 12 months ago (2014-12-23 01:04:21 UTC) #2
gab
lgtm, thanks!
5 years, 12 months ago (2014-12-23 21:55:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821673004/1
5 years, 12 months ago (2014-12-23 21:59:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/45397)
5 years, 12 months ago (2014-12-23 22:07:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821673004/1
5 years, 11 months ago (2014-12-27 13:09:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2014-12-27 13:10:18 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b4aadc32a7fd6d42ac3cc9adbb20a8ee4a267572 Cr-Commit-Position: refs/heads/master@{#309684}
5 years, 11 months ago (2014-12-27 13:11:00 UTC) #11
penny
5 years, 11 months ago (2014-12-29 20:30:54 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/833513002/ by pennymac@chromium.org.

The reason for reverting is: Changes breaks internal signing infrastructure
(static_assert not defined in environment somehow).

Maybe after the holidays, we can revisit!
.

Powered by Google App Engine